me/neoq
1
0
Fork 0
mirror of https://github.com/acaloiaro/neoq synced 2026-07-21 18:29:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Accumulation of cancel() funcs enqueueing on pg backend

Browse source 
`cancelFuncs` in the pg backend was intended for gracefully shutting down the backend with Shutdown(). Adding a
new cancel function every time a job is added to a queue isn't of any use, because there is nothing to "cancel" by
cancelling the context unless a job is in progress.

This was effectively a memory leak.
This commit is contained in:
Adriano Caloiaro 2023-09-16 16:53:27 +02:00 committed by Adriano Caloiaro
parent d66905fadd
commit bf2e07cf57
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
backends/postgres/postgres_backend.go
View file

@ -239,10 +239,6 @@ func (p *PgBackend) Enqueue(ctx context.Context, job *jobs.Job) (jobID string, e
}
p.logger.Debug("enqueueing job payload", slog.Any("job_payload", job.Payload))
ctx, cancel := context.WithCancel(ctx)
p.mu.Lock()
p.cancelFuncs = append(p.cancelFuncs, cancel)
p.mu.Unlock()
p.logger.Debug("acquiring new connection from connection pool")
conn, err := p.pool.Acquire(ctx)